-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add so3 package #5178
Add so3 package #5178
Conversation
Closes conan-io#5154
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁 |
This comment has been minimized.
This comment has been minimized.
@mdavezac could we move this PR to Ready for Review? |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Because 1.3.3 published prematurely to pipy and that's irrevocable.
This comment has been minimized.
This comment has been minimized.
Yes, that's the plan. It's in rc because there's a github action to push full releases to pypi |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: theirix <theirix@gmail.com>
This comment has been minimized.
This comment has been minimized.
recipes/so3/all/conanfile.py
Outdated
|
||
|
||
class So3Conan(ConanFile): | ||
name = "so3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "so3" | |
name = "astro-informatics-so3" |
I would rename it. The project SO3 provided by Astro Informatics is not so popular, only 3 github stars and there are other similar projects with same name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. We'll go with so3-transform, if that's allright. It will have to wait a few days though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uilianries unfortunately, the name so3 might be too generic (e.g. it stands for sulfur trioxide and few other things)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For libraries with a too generic name, like variant, the name of the organization can be used as prefix separated by a -, like mpark-variant
Our "rule" is the author/organization if you dont mind following the suggestion above
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the name change (I agree so3 is too generic) I would say the recipe is ready to go 🚀
This comment has been minimized.
This comment has been minimized.
Converting to draft until I've released the upstream and updated conandata.yml. |
Okay, upstream has been released and this recipe now points to it. |
All green in build 13 (
|
Thanks for all the help and comments! |
Closes #5154
conan-center hook activated.